Skip to content

fix: forbid bool value from JPEG's quality argument type. #8995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

fix: forbid bool value from JPEG's quality argument type. #8995

merged 3 commits into from
Mar 26, 2025

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Mar 23, 2025 •
edited by pytorch-bot bot
Loading

fix #8917

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8995

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cac8890 with merge base f3f2c35 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GdoongMathew

@NicolasHug NicolasHug merged commit 0f30dff into pytorch:main Mar 26, 2025
58 checks passed
@GdoongMathew GdoongMathew deleted the fix/jpeg_transform branch March 27, 2025 01:10
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Mar 27, 2025
@GdoongMathew @NicolasHug
fix: forbid bool value from JPEG's quality argument type. (pytorch#…
c68f4ed 
…8995)

Co-authored-by: Nicolas Hug <[email protected]>
facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2025
@NicolasHug @facebook-github-bot
[fbsync] fix: forbid bool value from JPEG's quality argument type. (#…
7798b29 
…8995)

Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: scotts

Differential Revision: D77998643

fbshipit-source-id: 4b5f54c2f888407093de769fd81ddde966bf5207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed enhancement module: transforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting float and bool values to quality argument of JPEG() gets the indirect errors

3 participants

@GdoongMathew @NicolasHug @facebook-github-bot